In default nextval('foo') expression for a SERIAL column, use double

quotes only when necessary.

In default nextval('foo') expression for a SERIAL column, use double
quotes only when necessary.
e80d6a1b · Tom Lane · 7662419f · e80d6a1b
Commit e80d6a1b authored May 28, 2002 by Tom Lane
Show whitespace changes
Inline Side-by-side

Showing with 2 additions and 3 deletions

src/backend/parser/analyze.c src/backend/parser/analyze.c +2 -3

No files found.
--- a/src/backend/parser/analyze.c
+++ b/src/backend/parser/analyze.c
@@ -6,7 +6,7 @@
 * Portions Copyright (c) 1996-2001, PostgreSQL Global Development Group
 * Portions Copyright (c) 1994, Regents of the University of California
 *
- *	$Header: /cvsroot/pgsql/src/backend/parser/analyze.c,v 1.234 2002/05/12 20:10:03 tgl Exp $
+ *	$Header: /cvsroot/pgsql/src/backend/parser/analyze.c,v 1.235 2002/05/28 22:15:42 tgl Exp $
 *
 *-------------------------------------------------------------------------
 */
@@ -856,8 +856,7 @@ transformColumnDefinition(ParseState *pstate, CreateStmtContext *cxt,
 		 * Create an expression tree representing the function call
 		 * nextval('"sequencename"')
 		 */
-		qstring = palloc(strlen(snamespace) + strlen(sname) + 5 + 1);
+		qstring = quote_qualified_identifier(snamespace, sname);
-		sprintf(qstring, "\"%s\".\"%s\"", snamespace, sname);
 		snamenode = makeNode(A_Const);
 		snamenode->val.type = T_String;
 		snamenode->val.val.str = qstring;