Commit b8fe12a8 authored by Noah Misch's avatar Noah Misch

Reconcile nodes/*funcs.c with recent work.

A few of the discrepancies had semantic significance, but I did not
track down the resulting user-visible bugs, if any.  Back-patch to 9.5,
where all but one discrepancy appeared.  The _equalCreateEventTrigStmt()
situation dates to 9.3 but does not affect semantics.

catversion bump due to readfuncs.c field order changes.
parent c2617066
...@@ -647,6 +647,7 @@ _copyCustomScan(const CustomScan *from) ...@@ -647,6 +647,7 @@ _copyCustomScan(const CustomScan *from)
* copy remainder of node * copy remainder of node
*/ */
COPY_SCALAR_FIELD(flags); COPY_SCALAR_FIELD(flags);
COPY_NODE_FIELD(custom_plans);
COPY_NODE_FIELD(custom_exprs); COPY_NODE_FIELD(custom_exprs);
COPY_NODE_FIELD(custom_private); COPY_NODE_FIELD(custom_private);
COPY_NODE_FIELD(custom_scan_tlist); COPY_NODE_FIELD(custom_scan_tlist);
...@@ -1925,9 +1926,9 @@ _copyOnConflictExpr(const OnConflictExpr *from) ...@@ -1925,9 +1926,9 @@ _copyOnConflictExpr(const OnConflictExpr *from)
COPY_SCALAR_FIELD(action); COPY_SCALAR_FIELD(action);
COPY_NODE_FIELD(arbiterElems); COPY_NODE_FIELD(arbiterElems);
COPY_NODE_FIELD(arbiterWhere); COPY_NODE_FIELD(arbiterWhere);
COPY_SCALAR_FIELD(constraint);
COPY_NODE_FIELD(onConflictSet); COPY_NODE_FIELD(onConflictSet);
COPY_NODE_FIELD(onConflictWhere); COPY_NODE_FIELD(onConflictWhere);
COPY_SCALAR_FIELD(constraint);
COPY_SCALAR_FIELD(exclRelIndex); COPY_SCALAR_FIELD(exclRelIndex);
COPY_NODE_FIELD(exclRelTlist); COPY_NODE_FIELD(exclRelTlist);
...@@ -4082,7 +4083,7 @@ _copyCreatePolicyStmt(const CreatePolicyStmt *from) ...@@ -4082,7 +4083,7 @@ _copyCreatePolicyStmt(const CreatePolicyStmt *from)
COPY_STRING_FIELD(policy_name); COPY_STRING_FIELD(policy_name);
COPY_NODE_FIELD(table); COPY_NODE_FIELD(table);
COPY_SCALAR_FIELD(cmd); COPY_STRING_FIELD(cmd);
COPY_NODE_FIELD(roles); COPY_NODE_FIELD(roles);
COPY_NODE_FIELD(qual); COPY_NODE_FIELD(qual);
COPY_NODE_FIELD(with_check); COPY_NODE_FIELD(with_check);
......
...@@ -759,9 +759,9 @@ _equalOnConflictExpr(const OnConflictExpr *a, const OnConflictExpr *b) ...@@ -759,9 +759,9 @@ _equalOnConflictExpr(const OnConflictExpr *a, const OnConflictExpr *b)
COMPARE_SCALAR_FIELD(action); COMPARE_SCALAR_FIELD(action);
COMPARE_NODE_FIELD(arbiterElems); COMPARE_NODE_FIELD(arbiterElems);
COMPARE_NODE_FIELD(arbiterWhere); COMPARE_NODE_FIELD(arbiterWhere);
COMPARE_SCALAR_FIELD(constraint);
COMPARE_NODE_FIELD(onConflictSet); COMPARE_NODE_FIELD(onConflictSet);
COMPARE_NODE_FIELD(onConflictWhere); COMPARE_NODE_FIELD(onConflictWhere);
COMPARE_SCALAR_FIELD(constraint);
COMPARE_SCALAR_FIELD(exclRelIndex); COMPARE_SCALAR_FIELD(exclRelIndex);
COMPARE_NODE_FIELD(exclRelTlist); COMPARE_NODE_FIELD(exclRelTlist);
...@@ -1868,8 +1868,8 @@ _equalCreateEventTrigStmt(const CreateEventTrigStmt *a, const CreateEventTrigStm ...@@ -1868,8 +1868,8 @@ _equalCreateEventTrigStmt(const CreateEventTrigStmt *a, const CreateEventTrigStm
{ {
COMPARE_STRING_FIELD(trigname); COMPARE_STRING_FIELD(trigname);
COMPARE_STRING_FIELD(eventname); COMPARE_STRING_FIELD(eventname);
COMPARE_NODE_FIELD(funcname);
COMPARE_NODE_FIELD(whenclause); COMPARE_NODE_FIELD(whenclause);
COMPARE_NODE_FIELD(funcname);
return true; return true;
} }
...@@ -2074,7 +2074,7 @@ _equalCreatePolicyStmt(const CreatePolicyStmt *a, const CreatePolicyStmt *b) ...@@ -2074,7 +2074,7 @@ _equalCreatePolicyStmt(const CreatePolicyStmt *a, const CreatePolicyStmt *b)
{ {
COMPARE_STRING_FIELD(policy_name); COMPARE_STRING_FIELD(policy_name);
COMPARE_NODE_FIELD(table); COMPARE_NODE_FIELD(table);
COMPARE_SCALAR_FIELD(cmd); COMPARE_STRING_FIELD(cmd);
COMPARE_NODE_FIELD(roles); COMPARE_NODE_FIELD(roles);
COMPARE_NODE_FIELD(qual); COMPARE_NODE_FIELD(qual);
COMPARE_NODE_FIELD(with_check); COMPARE_NODE_FIELD(with_check);
......
...@@ -341,7 +341,7 @@ _outModifyTable(StringInfo str, const ModifyTable *node) ...@@ -341,7 +341,7 @@ _outModifyTable(StringInfo str, const ModifyTable *node)
WRITE_NODE_FIELD(arbiterIndexes); WRITE_NODE_FIELD(arbiterIndexes);
WRITE_NODE_FIELD(onConflictSet); WRITE_NODE_FIELD(onConflictSet);
WRITE_NODE_FIELD(onConflictWhere); WRITE_NODE_FIELD(onConflictWhere);
WRITE_INT_FIELD(exclRelRTI); WRITE_UINT_FIELD(exclRelRTI);
WRITE_NODE_FIELD(exclRelTlist); WRITE_NODE_FIELD(exclRelTlist);
} }
...@@ -591,6 +591,7 @@ _outCustomScan(StringInfo str, const CustomScan *node) ...@@ -591,6 +591,7 @@ _outCustomScan(StringInfo str, const CustomScan *node)
_outScanInfo(str, (const Scan *) node); _outScanInfo(str, (const Scan *) node);
WRITE_UINT_FIELD(flags); WRITE_UINT_FIELD(flags);
WRITE_NODE_FIELD(custom_plans);
WRITE_NODE_FIELD(custom_exprs); WRITE_NODE_FIELD(custom_exprs);
WRITE_NODE_FIELD(custom_private); WRITE_NODE_FIELD(custom_private);
WRITE_NODE_FIELD(custom_scan_tlist); WRITE_NODE_FIELD(custom_scan_tlist);
...@@ -1016,7 +1017,7 @@ _outGroupingFunc(StringInfo str, const GroupingFunc *node) ...@@ -1016,7 +1017,7 @@ _outGroupingFunc(StringInfo str, const GroupingFunc *node)
WRITE_NODE_FIELD(args); WRITE_NODE_FIELD(args);
WRITE_NODE_FIELD(refs); WRITE_NODE_FIELD(refs);
WRITE_NODE_FIELD(cols); WRITE_NODE_FIELD(cols);
WRITE_INT_FIELD(agglevelsup); WRITE_UINT_FIELD(agglevelsup);
WRITE_LOCATION_FIELD(location); WRITE_LOCATION_FIELD(location);
} }
...@@ -1532,9 +1533,9 @@ _outOnConflictExpr(StringInfo str, const OnConflictExpr *node) ...@@ -1532,9 +1533,9 @@ _outOnConflictExpr(StringInfo str, const OnConflictExpr *node)
WRITE_ENUM_FIELD(action, OnConflictAction); WRITE_ENUM_FIELD(action, OnConflictAction);
WRITE_NODE_FIELD(arbiterElems); WRITE_NODE_FIELD(arbiterElems);
WRITE_NODE_FIELD(arbiterWhere); WRITE_NODE_FIELD(arbiterWhere);
WRITE_OID_FIELD(constraint);
WRITE_NODE_FIELD(onConflictSet); WRITE_NODE_FIELD(onConflictSet);
WRITE_NODE_FIELD(onConflictWhere); WRITE_NODE_FIELD(onConflictWhere);
WRITE_OID_FIELD(constraint);
WRITE_INT_FIELD(exclRelIndex); WRITE_INT_FIELD(exclRelIndex);
WRITE_NODE_FIELD(exclRelTlist); WRITE_NODE_FIELD(exclRelTlist);
} }
...@@ -1674,6 +1675,7 @@ _outCustomPath(StringInfo str, const CustomPath *node) ...@@ -1674,6 +1675,7 @@ _outCustomPath(StringInfo str, const CustomPath *node)
_outPathInfo(str, (const Path *) node); _outPathInfo(str, (const Path *) node);
WRITE_UINT_FIELD(flags); WRITE_UINT_FIELD(flags);
WRITE_NODE_FIELD(custom_paths);
WRITE_NODE_FIELD(custom_private); WRITE_NODE_FIELD(custom_private);
appendStringInfoString(str, " :methods "); appendStringInfoString(str, " :methods ");
_outToken(str, node->methods->CustomName); _outToken(str, node->methods->CustomName);
......
...@@ -538,7 +538,7 @@ _readGroupingFunc(void) ...@@ -538,7 +538,7 @@ _readGroupingFunc(void)
READ_NODE_FIELD(args); READ_NODE_FIELD(args);
READ_NODE_FIELD(refs); READ_NODE_FIELD(refs);
READ_NODE_FIELD(cols); READ_NODE_FIELD(cols);
READ_INT_FIELD(agglevelsup); READ_UINT_FIELD(agglevelsup);
READ_LOCATION_FIELD(location); READ_LOCATION_FIELD(location);
READ_DONE(); READ_DONE();
...@@ -1256,9 +1256,9 @@ _readOnConflictExpr(void) ...@@ -1256,9 +1256,9 @@ _readOnConflictExpr(void)
READ_ENUM_FIELD(action, OnConflictAction); READ_ENUM_FIELD(action, OnConflictAction);
READ_NODE_FIELD(arbiterElems); READ_NODE_FIELD(arbiterElems);
READ_NODE_FIELD(arbiterWhere); READ_NODE_FIELD(arbiterWhere);
READ_OID_FIELD(constraint);
READ_NODE_FIELD(onConflictSet); READ_NODE_FIELD(onConflictSet);
READ_NODE_FIELD(onConflictWhere); READ_NODE_FIELD(onConflictWhere);
READ_OID_FIELD(constraint);
READ_INT_FIELD(exclRelIndex); READ_INT_FIELD(exclRelIndex);
READ_NODE_FIELD(exclRelTlist); READ_NODE_FIELD(exclRelTlist);
......
...@@ -53,6 +53,6 @@ ...@@ -53,6 +53,6 @@
*/ */
/* yyyymmddN */ /* yyyymmddN */
#define CATALOG_VERSION_NO 201507282 #define CATALOG_VERSION_NO 201508062
#endif #endif
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment