Commit b3a47cdf authored by Tom Lane's avatar Tom Lane

Suppress compiler warning about unportable pointer value.

Setting a pointer value to "0xdeadbeef" draws a warning from some
compilers, and for good reason.  Be less cute and just set it to NULL.

In passing make some other cosmetic adjustments nearby.

Discussion: https://postgr.es/m/CAJrrPGdW3EkU-CRobvVKYf3fJuBdgWyuGeAbNzAQ4yBh+bfb_Q@mail.gmail.com
parent 14722c69
...@@ -95,7 +95,7 @@ logicalrep_read_commit(StringInfo in, LogicalRepCommitData *commit_data) ...@@ -95,7 +95,7 @@ logicalrep_read_commit(StringInfo in, LogicalRepCommitData *commit_data)
uint8 flags = pq_getmsgbyte(in); uint8 flags = pq_getmsgbyte(in);
if (flags != 0) if (flags != 0)
elog(ERROR, "unknown flags %u in commit message", flags); elog(ERROR, "unrecognized flags %u in commit message", flags);
/* read fields */ /* read fields */
commit_data->commit_lsn = pq_getmsgint64(in); commit_data->commit_lsn = pq_getmsgint64(in);
...@@ -468,7 +468,6 @@ logicalrep_read_tuple(StringInfo in, LogicalRepTupleData *tuple) ...@@ -468,7 +468,6 @@ logicalrep_read_tuple(StringInfo in, LogicalRepTupleData *tuple)
for (i = 0; i < natts; i++) for (i = 0; i < natts; i++)
{ {
char kind; char kind;
int len;
kind = pq_getmsgbyte(in); kind = pq_getmsgbyte(in);
...@@ -479,10 +478,13 @@ logicalrep_read_tuple(StringInfo in, LogicalRepTupleData *tuple) ...@@ -479,10 +478,13 @@ logicalrep_read_tuple(StringInfo in, LogicalRepTupleData *tuple)
tuple->changed[i] = true; tuple->changed[i] = true;
break; break;
case 'u': /* unchanged column */ case 'u': /* unchanged column */
tuple->values[i] = (char *) 0xdeadbeef; /* make bad usage more obvious */ /* we don't receive the value of an unchanged column */
tuple->values[i] = NULL;
break; break;
case 't': /* text formatted value */ case 't': /* text formatted value */
{ {
int len;
tuple->changed[i] = true; tuple->changed[i] = true;
len = pq_getmsgint(in, 4); /* read length */ len = pq_getmsgint(in, 4); /* read length */
...@@ -494,7 +496,7 @@ logicalrep_read_tuple(StringInfo in, LogicalRepTupleData *tuple) ...@@ -494,7 +496,7 @@ logicalrep_read_tuple(StringInfo in, LogicalRepTupleData *tuple)
} }
break; break;
default: default:
elog(ERROR, "unknown data representation type '%c'", kind); elog(ERROR, "unrecognized data representation type '%c'", kind);
} }
} }
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment