Commit a54d5875 authored by Tom Lane's avatar Tom Lane

Guard against null t->tm_zone in strftime.c.

The upstream IANA code does not guard against null TM_ZONE pointers in this
function, but in our code there is such a check in the other pre-existing
use of t->tm_zone.  We do have some places that set pg_tm.tm_zone to NULL.
I'm not entirely sure it's possible to reach strftime with such a value,
but I'm not sure it isn't either, so be safe.

Per Coverity complaint.
parent d4e59c55
...@@ -458,6 +458,7 @@ _fmt(const char *format, const struct pg_tm * t, char *pt, const char *ptlim, ...@@ -458,6 +458,7 @@ _fmt(const char *format, const struct pg_tm * t, char *pt, const char *ptlim,
negative = diff < 0; negative = diff < 0;
if (diff == 0) if (diff == 0)
{ {
if (t->tm_zone != NULL)
negative = t->tm_zone[0] == '-'; negative = t->tm_zone[0] == '-';
} }
if (negative) if (negative)
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment