Commit 9ca99cda authored by Heikki Linnakangas's avatar Heikki Linnakangas

Update relpages and reltuples estimates in stand-alone ANALYZE, even if

there's no analyzable attributes or indexes. We also used to report 0 live
and dead tuples for such tables, which messed with autovacuum threshold
calculations.

This fixes bug #4812 reported by George Su. Backpatch back to 8.1.
parent 7280fab7
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/analyze.c,v 1.136 2009/05/05 18:02:11 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/analyze.c,v 1.137 2009/05/19 08:30:00 heikki Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -363,19 +363,10 @@ analyze_rel(Oid relid, VacuumStmt *vacstmt, ...@@ -363,19 +363,10 @@ analyze_rel(Oid relid, VacuumStmt *vacstmt,
} }
/* /*
* Quit if no analyzable columns * Quit if no analyzable columns and no pg_class update needed.
*/ */
if (attr_cnt <= 0 && !analyzableindex) if (attr_cnt <= 0 && !analyzableindex && !update_reltuples)
{
/*
* We report that the table is empty; this is just so that the
* autovacuum code doesn't go nuts trying to get stats about a
* zero-column table.
*/
if (update_reltuples)
pgstat_report_analyze(onerel, 0, 0);
goto cleanup; goto cleanup;
}
/* /*
* Determine how many rows we need to sample, using the worst case from * Determine how many rows we need to sample, using the worst case from
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment