Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
959ee6d2
Commit
959ee6d2
authored
Jan 05, 2018
by
Bruce Momjian
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
pg_upgrade: simplify code layout in a few places
Backpatch-through: 9.4 (9.3 didn't need improving)
parent
df9f682c
Changes
2
Show whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
2 additions
and
8 deletions
+2
-8
src/bin/pg_upgrade/exec.c
src/bin/pg_upgrade/exec.c
+0
-2
src/bin/pg_upgrade/server.c
src/bin/pg_upgrade/server.c
+2
-6
No files found.
src/bin/pg_upgrade/exec.c
View file @
959ee6d2
...
@@ -112,7 +112,6 @@ exec_prog(const char *log_file, const char *opt_log_file,
...
@@ -112,7 +112,6 @@ exec_prog(const char *log_file, const char *opt_log_file,
pg_log
(
PG_VERBOSE
,
"%s
\n
"
,
cmd
);
pg_log
(
PG_VERBOSE
,
"%s
\n
"
,
cmd
);
#ifdef WIN32
#ifdef WIN32
/*
/*
* For some reason, Windows issues a file-in-use error if we write data to
* For some reason, Windows issues a file-in-use error if we write data to
* the log file from a non-primary thread just before we create a
* the log file from a non-primary thread just before we create a
...
@@ -194,7 +193,6 @@ exec_prog(const char *log_file, const char *opt_log_file,
...
@@ -194,7 +193,6 @@ exec_prog(const char *log_file, const char *opt_log_file,
}
}
#ifndef WIN32
#ifndef WIN32
/*
/*
* We can't do this on Windows because it will keep the "pg_ctl start"
* We can't do this on Windows because it will keep the "pg_ctl start"
* output filename open until the server stops, so we do the \n\n above on
* output filename open until the server stops, so we do the \n\n above on
...
...
src/bin/pg_upgrade/server.c
View file @
959ee6d2
...
@@ -310,12 +310,8 @@ start_postmaster(ClusterInfo *cluster, bool throw_error)
...
@@ -310,12 +310,8 @@ start_postmaster(ClusterInfo *cluster, bool throw_error)
* running.
* running.
*/
*/
if
(
!
pg_ctl_return
)
if
(
!
pg_ctl_return
)
{
pg_fatal
(
"pg_ctl failed to start the %s server, or connection failed
\n
"
,
if
(
cluster
==
&
old_cluster
)
cluster
==
&
old_cluster
?
"source"
:
"target"
);
pg_fatal
(
"pg_ctl failed to start the source server, or connection failed
\n
"
);
else
pg_fatal
(
"pg_ctl failed to start the target server, or connection failed
\n
"
);
}
return
true
;
return
true
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment