Commit 801386af authored by Tom Lane's avatar Tom Lane

Clarify old comment about qual_is_pushdown_safe's handling of subplans.

This comment glossed over the difference between initplans and subplans,
but they are indeed different for our purposes here.
parent 3848d216
...@@ -2840,9 +2840,11 @@ targetIsInAllPartitionLists(TargetEntry *tle, Query *query) ...@@ -2840,9 +2840,11 @@ targetIsInAllPartitionLists(TargetEntry *tle, Query *query)
* *
* Conditions checked here: * Conditions checked here:
* *
* 1. The qual must not contain any subselects (mainly because I'm not sure * 1. The qual must not contain any SubPlans (mainly because I'm not sure
* it will work correctly: sublinks will already have been transformed into * it will work correctly: SubLinks will already have been transformed into
* subplans in the qual, but not in the subquery). * SubPlans in the qual, but not in the subquery). Note that SubLinks that
* transform to initplans are safe, and will be accepted here because what
* we'll see in the qual is just a Param referencing the initplan output.
* *
* 2. If unsafeVolatile is set, the qual must not contain any volatile * 2. If unsafeVolatile is set, the qual must not contain any volatile
* functions. * functions.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment