Skip to content

P
Postgres FD Implementation
Commit 7ec280e1 authored by Tom Lane's avatar Tom Lane
Browse files
Options

Be careful to get share lock on each page before computing its free space. 

ITAGAKI Takahiro
parent 88ae1bd3
Show whitespace changes
Inline Side-by-side
Showing with 4 additions and 4 deletions
contrib/pgstattuple/pgstattuple.c
View file @ 7ec280e1
/* /*
* $PostgreSQL: pgsql/contrib/pgstattuple/pgstattuple.c,v 1.30 2007/09/20 17:56:30 tgl Exp $ * $PostgreSQL: pgsql/contrib/pgstattuple/pgstattuple.c,v 1.31 2007/10/22 17:29:35 tgl Exp $
* *
* Copyright (c) 2001,2002 Tatsuo Ishii * Copyright (c) 2001,2002 Tatsuo Ishii
* *
...@@ -291,8 +291,7 @@ pgstat_heap(Relation rel, FunctionCallInfo fcinfo) ...@@ -291,8 +291,7 @@ pgstat_heap(Relation rel, FunctionCallInfo fcinfo)
buffer = ReadBuffer(rel, block); buffer = ReadBuffer(rel, block);
LockBuffer(buffer, BUFFER_LOCK_SHARE); LockBuffer(buffer, BUFFER_LOCK_SHARE);
stat.free_space += PageGetHeapFreeSpace((Page) BufferGetPage(buffer)); stat.free_space += PageGetHeapFreeSpace((Page) BufferGetPage(buffer));
LockBuffer(buffer, BUFFER_LOCK_UNLOCK); UnlockReleaseBuffer(buffer);
ReleaseBuffer(buffer);
block++; block++;
} }
} }
...@@ -301,8 +300,9 @@ pgstat_heap(Relation rel, FunctionCallInfo fcinfo) ...@@ -301,8 +300,9 @@ pgstat_heap(Relation rel, FunctionCallInfo fcinfo)
while (block < nblocks) while (block < nblocks)
{ {
buffer = ReadBuffer(rel, block); buffer = ReadBuffer(rel, block);
LockBuffer(buffer, BUFFER_LOCK_SHARE);
stat.free_space += PageGetHeapFreeSpace((Page) BufferGetPage(buffer)); stat.free_space += PageGetHeapFreeSpace((Page) BufferGetPage(buffer));
ReleaseBuffer(buffer); UnlockReleaseBuffer(buffer);
block++; block++;
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment