Commit 6c8be596 authored by Alvaro Herrera's avatar Alvaro Herrera

Revert "Fix isolation test to be less timing-dependent"

This reverts commit 2268e6af.  It turned out that inconsistency in
the report is still possible, so go back to the simpler formulation of
the test and instead add an alternate expected output.

Discussion: https://postgr.es/m/20180103193728.ysqpcp2xjnqpiep7@alvherre.pgsql
parent 3e68686e
Parsed test spec with 3 sessions Parsed test spec with 2 sessions
starting permutation: s2l s1i s2i s3u
pg_advisory_lock
starting permutation: s2l s1i s2i
step s2l: SELECT pg_advisory_lock(281457); step s2l: SELECT pg_advisory_lock(281457);
pg_advisory_lock pg_advisory_lock
...@@ -14,11 +11,9 @@ step s1i: ...@@ -14,11 +11,9 @@ step s1i:
<waiting ...> <waiting ...>
step s2i: step s2i:
CREATE INDEX CONCURRENTLY mcic_two_pkey ON mcic_two (id) CREATE INDEX CONCURRENTLY mcic_two_pkey ON mcic_two (id)
WHERE unlck() AND lck_shr(572814); WHERE unlck();
<waiting ...>
step s3u: SELECT unlck(); step s1i: <... completed>
unlck unlck
t t
step s1i: <... completed>
step s2i: <... completed>
Parsed test spec with 2 sessions
starting permutation: s2l s1i s2i
step s2l: SELECT pg_advisory_lock(281457);
pg_advisory_lock
step s1i:
CREATE INDEX CONCURRENTLY mcic_one_pkey ON mcic_one (id)
WHERE lck_shr(281457);
<waiting ...>
step s2i:
CREATE INDEX CONCURRENTLY mcic_two_pkey ON mcic_two (id)
WHERE unlck();
<waiting ...>
step s1i: <... completed>
step s2i: <... completed>
unlck
t
...@@ -26,19 +26,15 @@ session "s1" ...@@ -26,19 +26,15 @@ session "s1"
step "s1i" { step "s1i" {
CREATE INDEX CONCURRENTLY mcic_one_pkey ON mcic_one (id) CREATE INDEX CONCURRENTLY mcic_one_pkey ON mcic_one (id)
WHERE lck_shr(281457); WHERE lck_shr(281457);
} }
step "s1u" { SELECT unlck(); } teardown { SELECT unlck(); }
session "s2" session "s2"
step "s2l" { SELECT pg_advisory_lock(281457); } step "s2l" { SELECT pg_advisory_lock(281457); }
step "s2i" { step "s2i" {
CREATE INDEX CONCURRENTLY mcic_two_pkey ON mcic_two (id) CREATE INDEX CONCURRENTLY mcic_two_pkey ON mcic_two (id)
WHERE unlck() AND lck_shr(572814); WHERE unlck();
} }
session "s3" permutation "s2l" "s1i" "s2i"
setup { SELECT pg_advisory_lock(572814); }
step "s3u" { SELECT unlck(); }
permutation "s2l" "s1i" "s2i" "s3u"
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment