Add a comment explaining why we force physical removal of OIDs.

Noah Misch, slightly revised.

Add a comment explaining why we force physical removal of OIDs.
Noah Misch, slightly revised.
5c2a7c6e · Robert Haas · a06e41de · 5c2a7c6e
Commit 5c2a7c6e authored Jan 26, 2011 by Robert Haas
Show whitespace changes
Inline Side-by-side

Showing with 3 additions and 1 deletion

src/backend/commands/tablecmds.c src/backend/commands/tablecmds.c +3 -1

No files found.
--- a/src/backend/commands/tablecmds.c
+++ b/src/backend/commands/tablecmds.c
@@ -4942,7 +4942,9 @@ ATExecDropColumn(List **wqueue, Relation rel, const char *colName,

 	/*
 	 * If we dropped the OID column, must adjust pg_class.relhasoids and tell
-	 * Phase 3 to physically get rid of the column.
+	 * Phase 3 to physically get rid of the column.  We formerly left the
+	 * column in place physically, but this caused subtle problems.  See
+	 * http://archives.postgresql.org/pgsql-hackers/2009-02/msg00363.php
 	 */
 	if (attnum == ObjectIdAttributeNumber)
 	{