Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Support
Keyboard shortcuts
?
Submit feedback
Contribute to GitLab
Sign in
Toggle navigation
P
Postgres FD Implementation
Project overview
Project overview
Details
Activity
Releases
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Issues
0
Issues
0
List
Boards
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Analytics
Analytics
CI / CD
Repository
Value Stream
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
Abuhujair Javed
Postgres FD Implementation
Commits
38710a37
Commit
38710a37
authored
Jan 22, 2016
by
Fujii Masao
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove unused argument from ginInsertCleanup()
It's an oversight in commit
dc943ad9
.
parent
c80b31d5
Changes
3
Show whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
6 additions
and
10 deletions
+6
-10
src/backend/access/gin/ginfast.c
src/backend/access/gin/ginfast.c
+2
-6
src/backend/access/gin/ginvacuum.c
src/backend/access/gin/ginvacuum.c
+3
-3
src/include/access/gin_private.h
src/include/access/gin_private.h
+1
-1
No files found.
src/backend/access/gin/ginfast.c
View file @
38710a37
...
...
@@ -434,7 +434,7 @@ ginHeapTupleFastInsert(GinState *ginstate, GinTupleCollector *collector)
END_CRIT_SECTION
();
if
(
needCleanup
)
ginInsertCleanup
(
ginstate
,
false
,
true
,
NULL
);
ginInsertCleanup
(
ginstate
,
true
,
NULL
);
}
/*
...
...
@@ -732,9 +732,6 @@ processPendingPage(BuildAccumulator *accum, KeyArray *ka,
* action of removing a page from the pending list really needs exclusive
* lock.
*
* vac_delay indicates that ginInsertCleanup should call
* vacuum_delay_point() periodically.
*
* fill_fsm indicates that ginInsertCleanup should add deleted pages
* to FSM otherwise caller is responsible to put deleted pages into
* FSM.
...
...
@@ -743,8 +740,7 @@ processPendingPage(BuildAccumulator *accum, KeyArray *ka,
*/
void
ginInsertCleanup
(
GinState
*
ginstate
,
bool
vac_delay
,
bool
fill_fsm
,
IndexBulkDeleteResult
*
stats
)
bool
fill_fsm
,
IndexBulkDeleteResult
*
stats
)
{
Relation
index
=
ginstate
->
index
;
Buffer
metabuffer
,
...
...
src/backend/access/gin/ginvacuum.c
View file @
38710a37
...
...
@@ -541,7 +541,7 @@ ginbulkdelete(IndexVacuumInfo *info, IndexBulkDeleteResult *stats,
/* Yes, so initialize stats to zeroes */
stats
=
(
IndexBulkDeleteResult
*
)
palloc0
(
sizeof
(
IndexBulkDeleteResult
));
/* and cleanup any pending inserts */
ginInsertCleanup
(
&
gvs
.
ginstate
,
true
,
false
,
stats
);
ginInsertCleanup
(
&
gvs
.
ginstate
,
false
,
stats
);
}
/* we'll re-count the tuples each time */
...
...
@@ -654,7 +654,7 @@ ginvacuumcleanup(IndexVacuumInfo *info, IndexBulkDeleteResult *stats)
if
(
IsAutoVacuumWorkerProcess
())
{
initGinState
(
&
ginstate
,
index
);
ginInsertCleanup
(
&
ginstate
,
true
,
true
,
stats
);
ginInsertCleanup
(
&
ginstate
,
true
,
stats
);
}
return
stats
;
}
...
...
@@ -667,7 +667,7 @@ ginvacuumcleanup(IndexVacuumInfo *info, IndexBulkDeleteResult *stats)
{
stats
=
(
IndexBulkDeleteResult
*
)
palloc0
(
sizeof
(
IndexBulkDeleteResult
));
initGinState
(
&
ginstate
,
index
);
ginInsertCleanup
(
&
ginstate
,
true
,
false
,
stats
);
ginInsertCleanup
(
&
ginstate
,
false
,
stats
);
}
memset
(
&
idxStat
,
0
,
sizeof
(
idxStat
));
...
...
src/include/access/gin_private.h
View file @
38710a37
...
...
@@ -946,7 +946,7 @@ extern void ginHeapTupleFastCollect(GinState *ginstate,
OffsetNumber
attnum
,
Datum
value
,
bool
isNull
,
ItemPointer
ht_ctid
);
extern
void
ginInsertCleanup
(
GinState
*
ginstate
,
bool
vac_delay
,
bool
fill_fsm
,
IndexBulkDeleteResult
*
stats
);
bool
fill_fsm
,
IndexBulkDeleteResult
*
stats
);
/* ginpostinglist.c */
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment