Commit 21d08bc1 authored by Vadim B. Mikheev's avatar Vadim B. Mikheev

PageAddItem in overwrite mode: must *NOT* check itemid' flag if

OffsetNumber == MaxOffsetNumber + 1 - there may be garbage there!
parent 3869b088
...@@ -8,7 +8,7 @@ ...@@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/storage/page/bufpage.c,v 1.35 2001/01/24 19:43:08 momjian Exp $ * $Header: /cvsroot/pgsql/src/backend/storage/page/bufpage.c,v 1.36 2001/02/06 06:24:00 vadim Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
...@@ -112,6 +112,8 @@ PageAddItem(Page page, ...@@ -112,6 +112,8 @@ PageAddItem(Page page,
elog(NOTICE, "PageAddItem: tried overwrite after maxoff"); elog(NOTICE, "PageAddItem: tried overwrite after maxoff");
return InvalidOffsetNumber; return InvalidOffsetNumber;
} }
if (offsetNumber < limit)
{
itemId = &((PageHeader) page)->pd_linp[offsetNumber - 1]; itemId = &((PageHeader) page)->pd_linp[offsetNumber - 1];
if (((*itemId).lp_flags & LP_USED) || if (((*itemId).lp_flags & LP_USED) ||
((*itemId).lp_len != 0)) ((*itemId).lp_len != 0))
...@@ -120,6 +122,7 @@ PageAddItem(Page page, ...@@ -120,6 +122,7 @@ PageAddItem(Page page,
return InvalidOffsetNumber; return InvalidOffsetNumber;
} }
} }
}
else else
{ {
/* /*
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment