Commit 1dad866b authored by Bruce Momjian's avatar Bruce Momjian

Someone report me small bug in contrib/pg_dumplo today. It's problem

with a little dirty snprintf() usage which I used some years ago:

    snprintf(path, BUFSIZ, "%s/lo_dump.index", path);

Karel Zak
parent 66871525
/* -------------------------------------------------------------------------
* pg_dumplo
*
* $Header: /cvsroot/pgsql/contrib/pg_dumplo/Attic/utils.c,v 1.6 2002/09/05 21:01:16 tgl Exp $
* $Header: /cvsroot/pgsql/contrib/pg_dumplo/Attic/utils.c,v 1.7 2003/10/09 13:38:05 momjian Exp $
*
* Karel Zak 1999-2000
* -------------------------------------------------------------------------
......@@ -30,6 +30,7 @@ void
index_file(LODumpMaster * pgLO)
{
char path[BUFSIZ];
int sz;
if (pgLO->action == ACTION_SHOW)
return;
......@@ -49,7 +50,8 @@ index_file(LODumpMaster * pgLO)
}
}
snprintf(path, BUFSIZ, "%s/lo_dump.index", path);
sz = strlen(path);
strncat(path, "/lo_dump.index", BUFSIZ-sz);
if ((pgLO->index = fopen(path, "w")) == NULL)
{
......@@ -60,8 +62,8 @@ index_file(LODumpMaster * pgLO)
}
else if (pgLO->action != ACTION_NONE)
{
snprintf(path, BUFSIZ, "%s/lo_dump.index", path);
sz = strlen(path);
strncat(path, "/lo_dump.index", BUFSIZ-sz);
if ((pgLO->index = fopen(path, "r")) == NULL)
{
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment