Commit 15b5d6cf authored by Bruce Momjian's avatar Bruce Momjian

I noticed in the 7.4 release that in contrib/pg_autovacuum, args->logfile is

not initialized if a log file is not specified on the command line.  This
causes an immediate segfault on systems that fill allocated memory with some
value other than zero (my FreeBSD machine uses 0xD0).

Several crashes later I discovered that args->user, password, host, and port
are also used without being initialized.

This doesn't appear to be fixed in CVS and I came up empty on a mailing list
search -- hope it hasn't been reported already.

Craig Boston
parent 5ef01a28
......@@ -811,6 +811,11 @@ get_cmd_args(int argc, char *argv[])
args->analyze_scaling_factor = -1;
args->debug = AUTOVACUUM_DEBUG;
args->daemonize = 0;
args->user = 0;
args->password = 0;
args->host = 0;
args->logfile = 0;
args->port = 0;
/*
* Fixme: Should add some sanity checking such as positive integer
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment