Commit 14ee3579 authored by Tom Lane's avatar Tom Lane

Fix portability bug in gin_page_opaque_info().

Somebody apparently thought that "if Int32GetDatum is good,
Int64GetDatum must be better".  Per buildfarm failures now
that Peter has added some regression tests here.
parent f7c9a6e0
...@@ -100,7 +100,7 @@ gin_page_opaque_info(PG_FUNCTION_ARGS) ...@@ -100,7 +100,7 @@ gin_page_opaque_info(PG_FUNCTION_ARGS)
GinPageOpaque opaq; GinPageOpaque opaq;
HeapTuple resultTuple; HeapTuple resultTuple;
Datum values[3]; Datum values[3];
bool nulls[10]; bool nulls[3];
Datum flags[16]; Datum flags[16];
int nflags = 0; int nflags = 0;
uint16 flagbits; uint16 flagbits;
...@@ -152,9 +152,9 @@ gin_page_opaque_info(PG_FUNCTION_ARGS) ...@@ -152,9 +152,9 @@ gin_page_opaque_info(PG_FUNCTION_ARGS)
memset(nulls, 0, sizeof(nulls)); memset(nulls, 0, sizeof(nulls));
values[0] = Int64GetDatum(opaq->rightlink); values[0] = Int64GetDatum(opaq->rightlink);
values[1] = Int64GetDatum(opaq->maxoff); values[1] = Int32GetDatum(opaq->maxoff);
values[2] = PointerGetDatum( values[2] = PointerGetDatum(construct_array(flags, nflags,
construct_array(flags, nflags, TEXTOID, -1, false, 'i')); TEXTOID, -1, false, 'i'));
/* Build and return the result tuple. */ /* Build and return the result tuple. */
resultTuple = heap_form_tuple(tupdesc, values, nulls); resultTuple = heap_form_tuple(tupdesc, values, nulls);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment