Commit 044b319c authored by Michael Paquier's avatar Michael Paquier

Fix some comments related to logical repslot advancing

confirmed_flush is part of a replication slot's information, but not
confirmed_lsn.

Author: Kyotaro Horiguchi
Discussion: https://postgr.es/m/20191226.175919.17237335658671970.horikyota.ntt@gmail.com
Backpatch-through: 11
parent 1ab41a3c
...@@ -378,8 +378,8 @@ pg_physical_replication_slot_advance(XLogRecPtr moveto) ...@@ -378,8 +378,8 @@ pg_physical_replication_slot_advance(XLogRecPtr moveto)
/* /*
* Helper function for advancing our logical replication slot forward. * Helper function for advancing our logical replication slot forward.
* *
* The slot's restart_lsn is used as start point for reading records, * The slot's restart_lsn is used as start point for reading records, while
* while confirmed_lsn is used as base point for the decoding context. * confirmed_flush is used as base point for the decoding context.
* *
* We cannot just do LogicalConfirmReceivedLocation to update confirmed_flush, * We cannot just do LogicalConfirmReceivedLocation to update confirmed_flush,
* because we need to digest WAL to advance restart_lsn allowing to recycle * because we need to digest WAL to advance restart_lsn allowing to recycle
...@@ -549,8 +549,8 @@ pg_replication_slot_advance(PG_FUNCTION_ARGS) ...@@ -549,8 +549,8 @@ pg_replication_slot_advance(PG_FUNCTION_ARGS)
/* /*
* Check if the slot is not moving backwards. Physical slots rely simply * Check if the slot is not moving backwards. Physical slots rely simply
* on restart_lsn as a minimum point, while logical slots have confirmed * on restart_lsn as a minimum point, while logical slots have confirmed
* consumption up to confirmed_lsn, meaning that in both cases data older * consumption up to confirmed_flush, meaning that in both cases data
* than that is not available anymore. * older than that is not available anymore.
*/ */
if (OidIsValid(MyReplicationSlot->data.database)) if (OidIsValid(MyReplicationSlot->data.database))
minlsn = MyReplicationSlot->data.confirmed_flush; minlsn = MyReplicationSlot->data.confirmed_flush;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment