• Alvaro Herrera's avatar
    psql: fix \connect with URIs and conninfo strings · fcef1617
    Alvaro Herrera authored
    psql was already accepting conninfo strings as the first parameter in
    \connect, but the way it worked wasn't sane; some of the other
    parameters would get the previous connection's values, causing it to
    connect to a completely unexpected server or, more likely, not finding
    any server at all because of completely wrong combinations of
    parameters.
    
    Fix by explicitely checking for a conninfo-looking parameter in the
    dbname position; if one is found, use its complete specification rather
    than mix with the other arguments.  Also, change tab-completion to not
    try to complete conninfo/URI-looking "dbnames" and document that
    conninfos are accepted as first argument.
    
    There was a weak consensus to backpatch this, because while the behavior
    of using the dbname as a conninfo is nowhere documented for \connect, it
    is reasonable to expect that it works because it does work in many other
    contexts.  Therefore this is backpatched all the way back to 9.0.
    
    To implement this, routines previously private to libpq have been
    duplicated so that psql can decide what looks like a conninfo/URI
    string.  In back branches, just duplicate the same code all the way back
    to 9.2, where URIs where introduced; 9.0 and 9.1 have a simpler version.
    In master, the routines are moved to src/common and renamed.
    
    Author: David Fetter, Andrew Dunstan.  Some editorialization by me
    (probably earning a Gierth's "Sloppy" badge in the process.)
    Reviewers: Andrew Gierth, Erik Rijkers, Pavel Stěhule, Stephen Frost,
    Robert Haas, Andrew Dunstan.
    fcef1617
connstrings.h 383 Bytes