• Robert Haas's avatar
    pg_upgrade: Don't overwrite existing files. · e191a690
    Robert Haas authored
    For historical reasons, copyFile and rewriteVisibilityMap took a force
    argument which was always passed as true, meaning that any existing
    file should be overwritten.  However, it seems much safer to instead
    fail if a file we need to write already exists.
    
    While we're at it, remove the "force" argument altogether, since it was
    never passed as anything other than true (and now we would never pass
    it as anything other than false, if we kept it).
    
    Noted by Andres Freund during post-commit review of the patch that added
    rewriteVisibilityMap, commit 7087166a,
    but this also changes the behavior when copying files without rewriting
    them.
    
    Patch by Masahiko Sawada.
    e191a690
relfilenode.c 7.35 KB