• Tom Lane's avatar
    Fix misuse of an integer as a bool. · ddf927fb
    Tom Lane authored
    pgtls_read_pending is declared to return bool, but what the underlying
    SSL_pending function returns is a count of available bytes.
    
    This is actually somewhat harmless if we're using C99 bools, but in
    the back branches it's a live bug: if the available-bytes count happened
    to be a multiple of 256, it would get converted to a zero char value.
    On machines where char is signed, counts of 128 and up could misbehave
    as well.  The net effect is that when using SSL, libpq might block
    waiting for data even though some has already been received.
    
    Broken by careless refactoring in commit 4e86f1b1, so back-patch
    to 9.5 where that came in.
    
    Per bug #15802 from David Binderman.
    
    Discussion: https://postgr.es/m/15802-f0911a97f0346526@postgresql.org
    ddf927fb
fe-misc.c 31.5 KB