• Stephen Frost's avatar
    Fix ordering in pg_dump of GRANTs · d2e40b31
    Stephen Frost authored
    The order in which GRANTs are output is important as GRANTs which have
    been GRANT'd by individuals via WITH GRANT OPTION GRANTs have to come
    after the GRANT which included the WITH GRANT OPTION.  This happens
    naturally in the backend during normal operation as we only change
    existing ACLs in-place, only add new ACLs to the end, and when removing
    an ACL we remove any which depend on it also.
    
    Also, adjust the comments in acl.h to make this clear.
    
    Unfortunately, the updates to pg_dump to handle initial privileges
    involved pulling apart ACLs and then combining them back together and
    could end up putting them back together in an invalid order, leading to
    dumps which wouldn't restore.
    
    Fix this by adjusting the queries used by pg_dump to ensure that the
    ACLs are rebuilt in the same order in which they were originally.
    
    Back-patch to 9.6 where the changes for initial privileges were done.
    d2e40b31
dumputils.c 24.7 KB