• Michael Paquier's avatar
    Fix fstat() emulation on Windows with standard streams · d2198b45
    Michael Paquier authored
    The emulation of fstat() in win32stat.c caused two issues with the
    existing in-core callers, failing on EINVAL when using a stream as
    argument:
    - psql's \copy would crash when using a stream.
    - pg_recvlogical would fail with -f -.
    
    The tests in copyselect.sql from the main test suite covers the first
    case, and there is a TAP test for the second case.  However, in both
    cases, as the standard streams are always redirected, automated tests
    did not notice those issues, requiring a terminal on Windows to be
    reproducible.
    
    This issue has been introduced in bed90759, and the origin of the problem
    is that GetFileInformationByHandle() does not work directly on streams,
    so this commit adds an extra code path to emulate and return a set of
    stats that match best with the reality.  Note that redirected streams
    rely on handles that can be queried with GetFileInformationByHandle(),
    but we can rely on GetFinalPathNameByHandleA() to detect this case.
    
    Author: Dmitry Koval, Juan José Santamaría Flecha
    Discussion: https://postgr.es/m/17288-6b58a91025a8a8a3@postgresql.org
    Backpatch-through: 14
    d2198b45
win32stat.c 7.66 KB