• Tom Lane's avatar
    Fix failure to ensure that a snapshot is available to datatype input functions · c98a9237
    Tom Lane authored
    when they are invoked by the parser.  We had been setting up a snapshot at
    plan time but really it needs to be done earlier, before parse analysis.
    Per report from Dmitry Koterov.
    
    Also fix two related problems discovered while poking at this one:
    exec_bind_message called datatype input functions without establishing a
    snapshot, and SET CONSTRAINTS IMMEDIATE could call trigger functions without
    establishing a snapshot.
    
    Backpatch to 8.2.  The underlying problem goes much further back, but it is
    masked in 8.1 and before because we didn't attempt to invoke domain check
    constraints within datatype input.  It would only be exposed if a C-language
    datatype input function used the snapshot; which evidently none do, or we'd
    have heard complaints sooner.  Since this code has changed a lot over time,
    a back-patch is hardly risk-free, and so I'm disinclined to patch further
    than absolutely necessary.
    c98a9237
analyze.c 63 KB