• Tom Lane's avatar
    Disable vacuum page skipping in selected test cases. · c2dc1a79
    Tom Lane authored
    By default VACUUM will skip pages that it can't immediately get
    exclusive access to, which means that even activities as harmless
    and unpredictable as checkpoint buffer writes might prevent a page
    from being processed.  Ordinarily this is no big deal, but we have
    a small number of test cases that examine the results of VACUUM's
    processing and therefore will fail if the page of interest is skipped.
    This seems to be the explanation for some rare buildfarm failures.
    To fix, add the DISABLE_PAGE_SKIPPING option to the VACUUM commands
    in tests where this could be an issue.
    
    In passing, remove a duplicated query in pageinspect/sql/page.sql.
    
    Back-patch as necessary (some of these cases are as old as v10).
    
    Discussion: https://postgr.es/m/413923.1611006484@sss.pgh.pa.us
    c2dc1a79
check_heap.out 6.99 KB