• Tom Lane's avatar
    Fix mishandling of column-level SELECT privileges for join aliases. · c028faf2
    Tom Lane authored
    scanNSItemForColumn, expandNSItemAttrs, and ExpandSingleTable would
    pass the wrong RTE to markVarForSelectPriv when dealing with a join
    ParseNamespaceItem: they'd pass the join RTE, when what we need to
    mark is the base table that the join column came from.  The end
    result was to not fill the base table's selectedCols bitmap correctly,
    resulting in an understatement of the set of columns that are read
    by the query.  The executor would still insist on there being at
    least one selectable column; but with a correctly crafted query,
    a user having SELECT privilege on just one column of a table would
    nonetheless be allowed to read all its columns.
    
    To fix, make markRTEForSelectPriv fetch the correct RTE for itself,
    ignoring the possibly-mismatched RTE passed by the caller.  Later,
    we'll get rid of some now-unused RTE arguments, but that risks
    API breaks so we won't do it in released branches.
    
    This problem was introduced by commit 9ce77d75, so back-patch
    to v13 where that came in.  Thanks to Sven Klemm for reporting
    the problem.
    
    Security: CVE-2021-20229
    c028faf2
privileges.out 76.8 KB