• Tom Lane's avatar
    Fix failure of "ALTER TABLE t ADD COLUMN c serial" when done by non-owner. · b5565bca
    Tom Lane authored
    The implicitly created sequence was created as owned by the current user,
    who could be different from the table owner, eg if current user is a
    superuser or some member of the table's owning role.  This caused sanity
    checks in the SEQUENCE OWNED BY code to spit up.  Although possibly we
    don't need those sanity checks, the safest fix seems to be to make sure
    the implicit sequence is assigned the same owner role as the table has.
    (We still do all permissions checks as the current user, however.)
    Per report from Josh Berkus.
    
    Back-patch to 9.0.  The bug goes back to the invention of SEQUENCE OWNED BY
    in 8.2, but the fix requires an API change for DefineRelation(), which seems
    to have potential for breaking third-party code if done in a minor release.
    Given the lack of prior complaints, it's probably not worth fixing in the
    stable branches.
    b5565bca
tablecmds.c 248 KB