• Tom Lane's avatar
    Fix contrib/bloom to work for unlogged indexes. · abaffa90
    Tom Lane authored
    blbuildempty did not do even approximately the right thing: it tried
    to add a metapage to the relation's regular data fork, which already
    has one at that point.  It should look like the ambuildempty methods
    for all the standard index types, ie, initialize a metapage image in
    some transient storage and then write it directly to the init fork.
    To support that, refactor BloomInitMetapage into two functions.
    
    In passing, fix BloomInitMetapage so it doesn't leave the rd_options
    field of the index's relcache entry pointing at transient storage.
    I'm not sure this had any visible consequence, since nothing much
    else is likely to look at a bloom index's rd_options, but it's
    certainly poor practice.
    
    Per bug #14155 from Zhou Digoal.
    
    Report: <20160524144146.22598.42558@wrigleys.postgresql.org>
    abaffa90
bloom.out 4.58 KB