• Tom Lane's avatar
    Don't downcase entries within shared_preload_libraries et al. · a69dfe5f
    Tom Lane authored
    load_libraries(), which processes the various xxx_preload_libraries GUCs,
    was parsing them using SplitIdentifierString() which isn't really
    appropriate for values that could be path names: it downcases unquoted
    text, and it doesn't allow embedded whitespace unless quoted.
    Use SplitDirectoriesString() instead.  That also allows us to simplify
    load_libraries() a bit, since canonicalize_path() is now done for it.
    
    While this definitely seems like a bug fix, it has the potential to
    break configuration settings that accidentally worked before because
    of the downcasing behavior.  Also, there's an easy workaround for the
    bug, namely to double-quote troublesome text.  Hence, no back-patch.
    
    QL Zhuo, tweaked a bit by me
    
    Discussion: https://postgr.es/m/CAB-oJtxHVDc3H+Km3CjB9mY1VDzuyaVH_ZYSz7iXcRqCtb93Ew@mail.gmail.com
    a69dfe5f
varlena.c 137 KB