• Tom Lane's avatar
    Tweak our special-case logic for the IANA "Factory" timezone. · 8ab66081
    Tom Lane authored
    pg_timezone_names() tries to avoid showing the "Factory" zone in
    the view, mainly because that has traditionally had a very long
    "abbreviation" such as "Local time zone must be set--see zic manual page",
    so that showing it messes up psql's formatting of the whole view.
    Since tzdb version 2016g, IANA instead uses the abbreviation "-00",
    which is sane enough that there's no reason to discriminate against it.
    
    On the other hand, it emerges that FreeBSD and possibly other packagers
    are so wedded to backwards compatibility that they hack the IANA data
    to keep the old spelling --- and not just that old spelling, but even
    older spellings that IANA used back in the stone age.  This caused the
    filter logic to fail to suppress "Factory" at all on such platforms,
    though the formatting problem is definitely real in that case.
    
    To solve both problems, get rid of the hard-wired assumption about
    exactly what Factory's abbreviation is, and instead reject abbreviations
    exceeding 31 characters.  This will allow Factory to appear in the view
    if and only if it's using the modern abbreviation.
    
    In passing, simplify the code we add to zic.c to support "zic -P"
    to remove its now-obsolete hacks to not print the Factory zone's
    abbreviation.  Unlike pg_timezone_names(), there's no reason for
    that code to support old/nonstandard timezone data.
    
    Since we generally prefer to keep timezone-related behavior the
    same in all branches, and since this is arguably a bug fix,
    back-patch to all supported branches.
    
    Discussion: https://postgr.es/m/3961.1564086915@sss.pgh.pa.us
    8ab66081
zic.c 85.5 KB