• Tom Lane's avatar
    Fix CREATE MATVIEW/CREATE TABLE AS ... WITH NO DATA to not plan the query. · 874fe3ae
    Tom Lane authored
    Previously, these commands always planned the given query and went through
    executor startup before deciding not to actually run the query if WITH NO
    DATA is specified.  This behavior is problematic for pg_dump because it
    may cause errors to be raised that we would rather not see before a
    REFRESH MATERIALIZED VIEW command is issued.  See for example bug #13907
    from Marian Krucina.  This change is not sufficient to fix that particular
    bug, because we also need to tweak pg_dump to issue the REFRESH later,
    but it's a necessary step on the way.
    
    A user-visible side effect of doing things this way is that the returned
    command tag for WITH NO DATA cases will now be "CREATE MATERIALIZED VIEW"
    or "CREATE TABLE AS", not "SELECT 0".  We could preserve the old behavior
    but it would take more code, and arguably that was just an implementation
    artifact not intended behavior anyhow.
    
    In 9.5 and HEAD, also get rid of the static variable CreateAsReladdr, which
    was trouble waiting to happen; there is not any prohibition on nested
    CREATE commands.
    
    Back-patch to 9.3 where CREATE MATERIALIZED VIEW was introduced.
    
    Michael Paquier and Tom Lane
    
    Report: <20160202161407.2778.24659@wrigleys.postgresql.org>
    874fe3ae
select_into.out 4.26 KB