• Tom Lane's avatar
    Repair unsafe use of shared typecast-lookup table in plpgsql DO blocks. · 83604cc4
    Tom Lane authored
    DO blocks use private simple_eval_estates to avoid intra-transaction memory
    leakage, cf commit c7b849a8.  I had forgotten about that while writing
    commit 0fc94a5b, but it means that expression execution trees created
    within a DO block disappear immediately on exiting the DO block, and hence
    can't safely be linked into plpgsql's session-wide cast hash table.
    To fix, give a DO block a private cast hash table to go with its private
    simple_eval_estate.  This is less efficient than one could wish, since
    DO blocks can no longer share any cast lookup work with other plpgsql
    execution, but it shouldn't be too bad; in any case it's no worse than
    what happened in DO blocks before commit 0fc94a5b.
    
    Per bug #13571 from Feike Steenbergen.  Preliminary analysis by
    Oleksandr Shulgin.
    83604cc4
plpgsql.sql 109 KB