• Thomas Munro's avatar
    Don't use _mdfd_getseg() in mdsyncfiletag(). · 7bb3102c
    Thomas Munro authored
    _mdfd_getseg() opens all segments up to the requested one.  That
    causes problems for mdsyncfiletag(), if mdunlinkfork() has
    already unlinked other segment files.  Open the file we want
    directly by name instead, if it's not already open.
    
    The consequence of this bug was a rare panic in the checkpointer,
    made more likely if you saturated the sync request queue so that
    the SYNC_FORGET_REQUEST messages for a given relation were more
    likely to be absorbed in separate cycles by the checkpointer.
    
    Back-patch to 12.  Defect in commit 3eb77eba.
    
    Author: Thomas Munro
    Reported-by: Justin Pryzby
    Discussion: https://postgr.es/m/20191119115759.GI30362%40telsasoft.com
    7bb3102c
md.c 38.9 KB