• Tom Lane's avatar
    Avoid possibly-unsafe use of Windows' FormatMessage() function. · 7abc1571
    Tom Lane authored
    Whenever this function is used with the FORMAT_MESSAGE_FROM_SYSTEM flag,
    it's good practice to include FORMAT_MESSAGE_IGNORE_INSERTS as well.
    Otherwise, if the message contains any %n insertion markers, the function
    will try to fetch argument strings to substitute --- which we are not
    passing, possibly leading to a crash.  This is exactly analogous to the
    rule about not giving printf() a format string you're not in control of.
    
    Noted and patched by Christian Ullrich.
    Back-patch to all supported branches.
    7abc1571
dirmod.c 9.19 KB