• Thomas Munro's avatar
    Hold interrupts while running dsm_detach() callbacks. · 637668fb
    Thomas Munro authored
    While cleaning up after a parallel query or parallel index creation that
    created temporary files, we could be interrupted by a statement timeout.
    The error handling path would then fail to clean up the files when it
    ran dsm_detach() again, because the callback was already popped off the
    list.  Prevent this hazard by holding interrupts while the cleanup code
    runs.
    
    Thanks to Heikki Linnakangas for this suggestion, and also to Kyotaro
    Horiguchi, Masahiko Sawada, Justin Pryzby and Tom Lane for discussion of
    this and earlier ideas on how to fix the problem.
    
    Back-patch to all supported releases.
    Reported-by: default avatarJustin Pryzby <pryzby@telsasoft.com>
    Discussion: https://postgr.es/m/20191212180506.GR2082@telsasoft.com
    637668fb
dsm.c 38.2 KB