• Alvaro Herrera's avatar
    Fix pg_dump's errno checking for zlib I/O · 4d57e838
    Alvaro Herrera authored
    Some error reports were reporting strerror(errno), which for some error
    conditions coming from zlib are wrong, resulting in confusing reports
    such as
      pg_restore: [compress_io] could not read from input file: Success
    which makes no sense.  To correctly extract the error message we need to
    use gzerror(), so let's do that.
    
    This isn't as comprehensive or as neat as I would like, but at least it
    should improve things in many common cases.  The zlib abstraction in
    compress_io does not seem to be applied consistently enough; we could
    perhaps improve that, but it seems master-only material, not a bug fix
    for back-patching.
    
    This problem goes back all the way, but I decided to apply back to 9.4
    only, because older branches don't contain commit 14ea8936 which this
    change depends on.
    
    Authors: Vladimir Kunschikov, Álvaro Herrera
    Discussion: https://postgr.es/m/1498120508308.9826@infotecs.ru
    4d57e838
pg_backup_directory.c 20.4 KB