• Barry Lind's avatar
    This patch fixes a bug reported by Graham Leggett (minfrin@sharp.fm). · 4bc8c8dd
    Barry Lind authored
    The bug was that any insert or update would fail if the returned oid was
    larger than a signed int.  Since OIDs are unsigned int's it was
    a bug that the code used a java signed int to deal with the values.  The bug
    would result in the error message: "Unable to fathom update count".
    While fixing the bug, it became apparent that other code made a similar
    assumption about OIDs being signed ints.  Therefore some methods that returned
    or took OIDs are arguements also needed to be changed.
    Since we are so close to the 7.2 release I have added new methods that
    return longs and deprecated the old methods returning ints.  Therefore all
    old code should still work without requiring a code change to cast from long to int.  Also note that the methods below are PostgreSQL specific extensions to
    the JDBC api are are not part of the spec from Sun, thus it is unlikely that
    they are used much or at all.
    
    The deprecated methods are:
      ResultSet.getInsertedOID()
      Statement.getInsertedOID()
      Serialize.store()
      Connection.putObject()
    and are replaced by:
      ResultSet.getLastOID()
      Statement.getLastOID()
      Serialize.storeObject()
      Connection.storeObject()
    All the deprecated methods returned int, while their replacements return long
    
    This patch also fixes two comments in MD5Digest that the author Jeremy Wohl
    submitted.
    
    --Barry
    4bc8c8dd
UpdateableResultSet.java 7.29 KB