• Tom Lane's avatar
    Introduce macros for typalign and typstorage constants. · 3ed2005f
    Tom Lane authored
    Our usual practice for "poor man's enum" catalog columns is to define
    macros for the possible values and use those, not literal constants,
    in C code.  But for some reason lost in the mists of time, this was
    never done for typalign/attalign or typstorage/attstorage.  It's never
    too late to make it better though, so let's do that.
    
    The reason I got interested in this right now is the need to duplicate
    some uses of the TYPSTORAGE constants in an upcoming ALTER TYPE patch.
    But in general, this sort of change aids greppability and readability,
    so it's a good idea even without any specific motivation.
    
    I may have missed a few places that could be converted, and it's even
    more likely that pending patches will re-introduce some hard-coded
    references.  But that's not fatal --- there's no expectation that
    we'd actually change any of these values.  We can clean up stragglers
    over time.
    
    Discussion: https://postgr.es/m/16457.1583189537@sss.pgh.pa.us
    3ed2005f
subscriptioncmds.c 31.6 KB