• Tom Lane's avatar
    Include TableFunc references when computing expression dependencies. · 2c7b5dad
    Tom Lane authored
    The TableFunc node (i.e., XMLTABLE) includes type and collation OIDs
    that might not be referenced anywhere else in the expression tree,
    so they need to be accounted for when extracting dependencies.
    
    Fortunately, the practical effects of this are limited, since
    (a) it's somewhat unlikely that people would be extracting
    columns of non-builtin types from an XML document, and (b)
    in many scenarios, the query would contain other references
    to such types, or functions depending on them.  However, it's
    not hard to construct examples wherein the existing code lets
    one drop a type used in XMLTABLE and thereby break a view.
    
    This is evidently an original oversight in the XMLTABLE patch,
    so back-patch to v10 where that came in.
    
    Discussion: https://postgr.es/m/18427.1573508501@sss.pgh.pa.us
    2c7b5dad
dependency.c 85.7 KB