• Tom Lane's avatar
    Fix up handling of nondeterministic collations with pattern_ops opclasses. · 28103963
    Tom Lane authored
    text_pattern_ops and its siblings can't be used with nondeterministic
    collations, because they use the text_eq operator which will not behave
    as bitwise equality if applied with a nondeterministic collation.  The
    initial implementation of that restriction was to insert a run-time test
    in the related comparison functions, but that is inefficient, may throw
    misleading errors, and will throw errors in some cases that would work.
    It seems sufficient to just prevent the combination during CREATE INDEX,
    so do that instead.
    
    Lacking any better way to identify the opclasses involved, we need to
    hard-wire tests for them, which requires hand-assigned values for their
    OIDs, which forces a catversion bump because they previously had OIDs
    that would be assigned automatically.  That's slightly annoying in the
    v12 branch, but fortunately we're not at rc1 yet, so just do it.
    
    Back-patch to v12 where nondeterministic collations were added.
    
    In passing, run make reformat-dat-files, which found some unrelated
    whitespace issues (slightly different ones in HEAD and v12).
    
    Peter Eisentraut, with small corrections by me
    
    Discussion: https://postgr.es/m/22566.1568675619@sss.pgh.pa.us
    28103963
index.c 122 KB