• Kevin Grittner's avatar
    Fix `make installcheck` for serializable transactions. · 253de7e1
    Kevin Grittner authored
    Commit e5550d5f added some new
    tests for ALTER TABLE which involved table scans.  When
    default_transaction_isolation = 'serializable' these acquire
    relation-level SIReadLocks.  The test results didn't cope with
    that.  Add SIReadLock as the minimum lock level for purposes of
    these tests.
    
    This could also be fixed by excluding this type of lock from the
    my_locks view, but it would be a bug for SIReadLock to show up for
    a relation which was not otherwise locked, so do it this way to
    allow that sort of condition to cause a regression test failure.
    
    There is some question whether we could avoid taking SIReadLocks
    during these operations, but confirming the safety of that and
    figuring out how to avoid the locks is not trivial, and would be
    a separate patch.
    
    Backpatch to 9.4 where the new tests were added.
    253de7e1
alter_table.sql 60 KB