• Tom Lane's avatar
    Prevent planagg.c from failing on queries containing CTEs. · 1f542a2e
    Tom Lane authored
    The existing tests in preprocess_minmax_aggregates() usually prevent it
    from trying to do anything with queries containing CTEs, but there's an
    exception: a CTE could be present as a member of an appendrel, if we
    flattened a UNION ALL that contains CTE references.  If it did try to
    generate an optimized path for a query using a CTE, it failed with
    "could not find plan for CTE", as reported by Torsten Förtsch.
    
    The proximate cause is an unwise decision in commit 3fc6e2d7 to clear
    subroot->cte_plan_ids in build_minmax_path().  That left the subroot's
    cte_plan_ids list out of step with its parse->cteList.
    
    Removing the "subroot->cte_plan_ids = NIL;" assignment is enough to let
    the case work again, but really it's pretty silly to be expending any
    cycles at all in this module when there are CTEs: we always treat their
    outputs as unordered so there's no way for the optimization to win.
    Hence, also add an early-exit test so we don't waste time like that.
    
    Back-patch to 9.6 where the misbehavior was introduced.
    
    Report: https://postgr.es/m/CAKkG4_=gjY5QiHtqSZyWMwDuTd_CftKoTaCqxjJ7uUz1-Gw=qw@mail.gmail.com
    1f542a2e
planagg.c 17.1 KB