• Tom Lane's avatar
    Find postgresql.auto.conf in PGDATA even when postgresql.conf is elsewhere. · 195e81af
    Tom Lane authored
    The original coding for ALTER SYSTEM made a fundamentally bogus assumption
    that postgresql.auto.conf could be sought relative to the main config file
    if we hadn't yet determined the value of data_directory.  This fails for
    common arrangements with the config file elsewhere, as reported by
    Christoph Berg.
    
    The simplest fix is to not try to read postgresql.auto.conf until after
    SelectConfigFiles has chosen (and locked down) the data_directory setting.
    
    Because of the logic in ProcessConfigFile for handling resetting of GUCs
    that've been removed from the config file, we cannot easily read the main
    and auto config files separately; so this patch adopts a brute force
    approach of reading the main config file twice during postmaster startup.
    That's a tad ugly, but the actual time cost is likely to be negligible,
    and there's no time for a more invasive redesign before beta.
    
    With this patch, any attempt to set data_directory via ALTER SYSTEM
    will be silently ignored.  It would probably be better to throw an
    error, but that can be dealt with later.  This bug, however, would
    prevent any testing of ALTER SYSTEM by a significant fraction of the
    userbase, so it seems important to get it fixed before beta.
    195e81af
guc.c 239 KB