• Michael Paquier's avatar
    Improve failure detection with array parsing in pg_dump · 13b58f89
    Michael Paquier authored
    Similarly to 3636efa1, the checks done in pg_dump when parsing array
    values from catalogs have been too lax.  Under memory pressure, it could
    be possible, though very unlikely, to finish with dumps that miss some
    data like:
    - Statistics for indexes
    - Run-time configuration of functions
    - Configuration of extensions
    - Publication list for a subscription
    
    No backpatch is done as this is not going to be a problem in practice.
    For example, if an OOM causes an array parsing to fail, a follow-up code
    path of pg_dump would most likely complain with an allocation failure
    due to the memory pressure.
    
    Author: Michael Paquier
    Reviewed-by: Daniel Gustafsson
    Discussion: https://postgr.es/m/20201111061319.GE2276@paquier.xyz
    13b58f89
pg_dump.c 565 KB