• Tom Lane's avatar
    Fix pg_get_indexdef()'s behavior for included index columns. · 028e3da2
    Tom Lane authored
    The multi-argument form of pg_get_indexdef() failed to print anything when
    asked to print a single index column that is an included column rather than
    a key column.  This seems an unintentional result of someone having tried
    to take a short-cut and use the attrsOnly flag for two different purposes.
    To fix, split said flag into two flags, attrsOnly which suppresses
    non-attribute info, and keysOnly which suppresses included columns.
    Add a test case using psql's \d command, which relies on that function.
    
    (It's mighty tempting at this point to replace pg_get_indexdef_worker's
    mess of boolean flag arguments with a single bitmask-of-flags argument,
    which would allow making the call sites much more self-documenting.
    But I refrained for the moment.)
    
    Discussion: https://postgr.es/m/21724.1531943735@sss.pgh.pa.us
    028e3da2
index_including.sql 9.64 KB